feat(webapp): storybook gallery for the dashboard agent - #4516
feat(webapp): storybook gallery for the dashboard agent#4516kathiekiwi wants to merge 9 commits into
Conversation
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughAdded client-safe dashboard-agent demo fixtures for investigations, diagnoses, charts, intents, watches, messages, reports, and identifiers. Added reusable chart and intent components. Replaced the agent Storybook route with a manifest-driven gallery for chat, view blocks, reports, investigations, watches, prompts, banners, and wake states. Added dedicated Storybook routes for view blocks, reports, investigations, and watches. Added toast examples and expanded Vitest coverage for fixture schemas, rendering states, navigation targets, and source isolation. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
kathiekiwi
changed the title
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
bfe64cc to
1b6dfb1
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
712396b to
e110e90
Compare
662e92f to
02e1f60
Compare
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
ec08b16 to
c43d49f
Compare
c0f0058 to
e7432a8
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
c43d49f to
a71b7e0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
a71b7e0 to
6587840
Compare
3a64fb0 to
4dc89f6
Compare
6587840 to
fc9ce3b
Compare
4dc89f6 to
5cddeb8
Compare
fc9ce3b to
3a8fbcc
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
5cddeb8 to
f1f8c97
Compare
3a8fbcc to
305742d
Compare
f1f8c97 to
6fbdbbc
Compare
305742d to
de64d25
Compare
6fbdbbc to
59eaf24
Compare
de64d25 to
0a00abd
Compare
59eaf24 to
6606ee2
Compare
0a00abd to
d4911ca
Compare
6606ee2 to
6630047
Compare
d4911ca to
9a1383f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
6630047 to
59378cf
Compare
9a1383f to
9c6dd03
Compare
| @@ -0,0 +1,290 @@ | |||
| // Keep this file free of imports and JSX so plain node can read it. | |||
There was a problem hiding this comment.
🔍 Server-changes note: intentionally absent, worth confirming with a maintainer
CONTRIBUTING.md / .server-changes/README.md ask for a .server-changes/ entry on PRs that touch only apps/webapp/. This PR does, but everything it adds is admin-only storybook and demo fixtures, and .server-changes/dashboard-agent.md already exists on main covering the user-facing feature; the description states this split intentionally carries nothing user-facing. Flagging so a maintainer can confirm no release note is expected here rather than having it silently dropped.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Intentionally absent, and I think correctly. .server-changes/ entries ship verbatim in user-facing release notes, and this PR changes nothing a user can see: every file is under storybook.agent-ui/, dashboard-agent/demo/, a test, or the vitest include. git diff --name-only against its base returns 0 files outside those.
A note here would say "we added an internal component gallery", which is not a release note.
The user-visible work in this stack is covered by the note on #4418, which the branches above inherit.
9c6dd03 to
ec43fb7
Compare
004f088 to
e954d82
Compare
The gallery pages for the agent chat, view blocks, report, investigation and watch cards, the demo fixtures behind them, and the screenshot script. This reverts commit bbdcb0881, which held these back out of the parent PR.
…d pin them to the code that reads them The confirmation card's external notification became a three-state object while the gallery branch sat still, and the report card's untrustworthy reason was renamed under a free-form key that nothing typechecked. Moves the hand-written fixtures into the shared gallery module and checks them against the schemas and readers the product uses, so the next rename fails a test instead of rendering an unreachable state.
The barrel re-exports React components, and this suite runs without a DOM.
Never exported from the demo barrel and never called on any branch in the stack.
ec43fb7 to
5755c4a
Compare
1 participant
Split out of #4418 so that PR carries only what ships to users.
Adds the agent gallery: five
storybook.agent-*pages (chat UI, view blocks, report, investigation, watch) with their shared shell and manifest, the demo fixtures and two demo-only cards that feed them, the agent toast examples, and the screenshot script.